Pull requests
Docs15 min
Pull requests
A PR is a conversation with a beginning (the diff), a middle (review), and an end (the merge). The reviewer's time is the scarce resource:
- Small diff. Under ~400 changed lines, reviews find real problems; over
~1000, they rubber-stamp.
- Title says what + why. "Add lesson content" beats "update files".
- Describe the risky part. Point the reviewer at the one thing you are
unsure about.
This app's own PR #6 — auth with JWT cookies — merged into this branch with five real conflicts resolved. A PR done well is a lesson for the whole team.
Exercise
Open a real PR on this repo (any small fix). Write its description: what, why, how tested, and what you want reviewed closely.